fix(tui): restore activity picker/edit behavior after runtime refactor#94
Merged
fix(tui): restore activity picker/edit behavior after runtime refactor#94
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e4dfda9c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
ponbac
force-pushed
the
tui-fix-stale-activity-selection
branch
from
0e4dfda to
775556a
Compare
Collaborator
|
Tested and verified, so I believe this should be safe to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR fixes a critical bug where the activity picker wouldn't properly load activities when editing historical entries after the runtime refactor. The fix ensures activities are loaded asynchronously via the action queue before opening the picker.
KeyEventKind::Pressevents onlyensure_activities_for_projecthelper functionOpenEditActivityPickeraction to handle async activity loading in edit modehandle_entry_edit_entersignature to accept action queue for proper async handlingConfidence Score: 5/5
Important Files Changed
KeyEventKind::Pressfilter to prevent duplicate key event processing from key releasesOpenEditActivityPickeraction to support async activity loading when editing entriesensure_activities_for_projecthelper; updatedhandle_entry_edit_enterto use action queue for async operationsclear_project_activityandclear_notemethods; activity picker now resets search state on exit for clean re-entryhandle_entry_edit_enterwith action queue parameterhandle_entry_edit_enterto pass action queue parameter for async activity loadingLast reviewed commit: 0e4dfda